[SDK-386] embedded card improvements#1009
Open
franco-zalamena-iterable wants to merge 7 commits intomasterfrom
Open
[SDK-386] embedded card improvements#1009franco-zalamena-iterable wants to merge 7 commits intomasterfrom
franco-zalamena-iterable wants to merge 7 commits intomasterfrom
Conversation
franco-zalamena-iterable
force-pushed
the
SDK-386-embedded-card-image-height
branch
from
c1fb274 to
e35c809
Compare
sumeruchat
requested changes
Apr 8, 2026
Contributor
sumeruchat
left a comment
sumeruchat
left a comment
There was a problem hiding this comment.
• The UI/layout changes look reasonable, but the public IterableEmbeddedViewConfig constructor change introduces a source-compatibility regression for
existing Java consumers of the SDK. That makes the patch incorrect as a library change until compatibility is preserved.
Review comment:
- [P2] Preserve Java source compatibility for IterableEmbeddedViewConfig — /Users/sumeru.chatterjee/MyProjects/iterable-android-sdk/iterableapi-ui/src/main/
java/com/iterable/iterableapi/ui/embedded/IterableEmbeddedViewConfig.kt:5-16
If an app integrates this SDK from Java and already calls new IterableEmbeddedViewConfig(...), this change breaks compilation on upgrade because Kotlin
default parameters do not create a shorter Java overload. Adding imageScaleType changes the only public constructor from 10 args to 11 args, so every
existing Java call site now fails until it is updated manually.
Without @jvmoverloads, Java callers must pass all 11 constructor parameters since Kotlin default values are not visible to Java. This generates overloaded constructors so Java consumers can omit trailing parameters with defaults. Made-with: Cursor
Revert button style from TextButton back to the original filled MaterialButton to preserve backwards compatibility. The style change from filled to text-only is a visual breaking change for existing users. Made-with: Cursor
Resolve CHANGELOG.md conflict by combining both sets of entries. Updated embedded card fix description to remove the button style mention since that change was reverted. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description
Improvements to the Card Embedded View Image
NEW image scale type config option for the embedded view
The Card Embedded view currently has display issues for the buttons, with them showing up with a start padding that made them unaligned. To match the campaign preview we need to check how to deal with this
The image from the card embedded now has an aspect ratio field that can be configured by the new image scale type field
closes #997